Messages in this thread | | | Subject | Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c | From | Dmitry Osipenko <> | Date | Tue, 21 Dec 2021 18:56:36 +0300 |
| |
20.12.2021 20:06, Peter Geis пишет: > This adds reboot support to the rk808 pmic driver and enables it for > the rk809 and rk817 devices. > This only enables if the rockchip,system-power-controller flag is set. > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > Reviewed-by: Dmitry Osipenko <digetx@gmail.com> > --- > This patch was created to address issues with psci-reset on rk356x > chips. Until the rk356x series ATF open source code is released so we > can fix the issue at the source, this is the only way to ensure reliable > resetting on devices using these chips. > > After testing the rk808 (thanks Robin!), it was found DEV_OFF_RST does > not reset the PMIC to a power on state. Since the rk805 and rk818 match > this register layout, I'm removing support for all three in the v2. > It may be possible to add support to them using an RTC wakeup, but that > has not been explored and is outside the scope of this patch. > > Changelog: > V4: > - reorder rk808_restart_notify (Thanks Dmitry) > - drop of_property_read_bool before unregister (Good catch Frank)
Might be better to resend it with v4 in the commit title, to avoid confusion.
| |