| Date | Tue, 21 Dec 2021 16:42:20 +0100 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 04/11] PCI: pci-bridge-emul: Add support for new flag PCI_BRIDGE_EMUL_NO_IO_FORWARD |
| |
On Tue, 21 Dec 2021 15:14:48 +0100 Pali Rohár <pali@kernel.org> wrote:
> Like PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD, this new flag specifies that > emulated PCI bridge does not support forwarding of IO requests in given > range between primary and secondary buses. This flag should be used as > argument for pci_bridge_emul_init() for hardware setup without IO support. > > Setting this flag cause that IO base and limit registers are read-only. > > Signed-off-by: Pali Rohár <pali@kernel.org>
Looks good. As said on PATCH 03/11, perhaps just a snippet of documentation in pci-bridge-emul.h to describe the semantic of the new flag.
Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com
|