lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/3] Add missing format_mod_supported functions
On Tue, 21 Dec 2021 at 13:13, José Expósito <jose.exposito89@gmail.com> wrote:
>
> Hi all,
>
> When setting IN_FORMATS, implementing the
> "drm_plane_funcs.format_mod_supported" function is mandatory to avoid
> exposing a bogus blob.
>
> This patchset adds a bit of documentation and fixes the issue in a
> couple of drivers affected by the bug.
>
> I reviewed all the other drivers and I didn't find more instances of
> the issue.
>
> Jose
>
> José Expósito (3):
> drm/plane: Mention format_mod_supported in IN_FORMATS docs
> drm/msm/mdp4: Add format_mod_supported function
> drm/sun4i: Add format_mod_supported function
>
> drivers/gpu/drm/drm_plane.c | 7 +++++--
> drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 8 ++++++++

You missed mdp5_plane.c here. But I assume that the proposed fix is
not correct, see my comments on patch 1.

> drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 7 +++++++
> drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 7 +++++++
> 4 files changed, 27 insertions(+), 2 deletions(-)
>
> --
> 2.25.1
>


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2021-12-21 11:50    [W:0.070 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site