Messages in this thread | | | Date | Tue, 21 Dec 2021 11:49:06 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/4] x86/entry: Make paranoid_exit() callable |
| |
On Tue, Dec 21, 2021 at 10:22:48AM +0800, Lai Jiangshan wrote: > When paranoid_exit() is ready to be converted to C, it can't have jump to > any label that is not in paranoid_exit() itself.
Then splitting out those 4 patches from the rest of the series was not the right thing to do. Because how is a reviewer to know what your final goal is without seeing it?
When I told you at the time that you could split the big patchset out, I said:
"It might be even helpful if you could split it into more palatable portions of maybe 10-ish patches each, if possible, and then send the first portion, wait for review and only send the second portion after the first has been applied, etc."
Maybe I should have explained what "if possible" means: if a subset can exist on its own and is logically separate, then it should be split. But, if, as in this case, it looks like introducing arbitrary changes then I wouldn't do that.
IMNSVHO, ofc.
HTH.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |