lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] software node: fix wrong node passed to find nargs_prop
Hi Greg, Andy,

On Tue, Dec 21, 2021 at 10:34:11AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 20, 2021 at 11:37:07PM +0000, Daniel Scally wrote:
> > Thanks Andy
> >
> > On 20/12/2021 22:13, Andy Shevchenko wrote:
> > > + Sakari, Dan
> > >
> > > On Monday, December 20, 2021, Clément Léger <clement.leger@bootlin.com
> > > <mailto:clement.leger@bootlin.com>> wrote:
> > >
> > > nargs_prop refers to a property located in the reference that is found
> > > within the nargs property.
> >
> > I think this is right (it's not used in the ACPI version, and the OF
> > version is quite convoluted so a bit hard to follow)...but also I note
> > that none of the users of fwnode_property_get_reference_args() pass
> > anything to nargs_prop anyway...do we even need this?
>
> Looks like it is unused, please just remove it.

If you remove nargs_prop argument, then callers will have to use OF
property API instead to parse references with property-defined number of
arguments. The goal has been to cover all functionality in a
firmware-independent way.

--
Regards,

Sakari Ailus

\
 
 \ /
  Last update: 2021-12-21 10:45    [W:0.064 / U:1.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site