lkml.org 
[lkml]   [2021]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] watchdog: ie6xx_wdt: Check for null res pointer
    Date
    On 12/19/21 10:21 PM, Jiasheng Jiang wrote:
    > The return value of platform_get_resource() needs to be checked.
    > To avoid use of error pointer in case that there is no suitable resource.
    >

    How would that resource disappear since the probe function ?

    That driver could use a lot of cleanup (use devm_request_region(),
    use watchdog_stop_on_unregister(), stop using a static data structure,
    use devm_add_action_or_reset to trigger the call to debugfs_remove,
    use devm_watchdog_register_device and drop the remove function),
    but this change addresses a non-existing problem.

    Guenter

    > Fixes: 101ce87b3bdd ("watchdog: Add watchdog driver for Intel Atom E6XX")
    > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    > ---
    > Changelog:
    >
    > v1 -> v2
    >
    > *Change 1. Correct the commit message.
    > ---
    > drivers/watchdog/ie6xx_wdt.c | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/drivers/watchdog/ie6xx_wdt.c b/drivers/watchdog/ie6xx_wdt.c
    > index 8f28993fab8b..ee5b68d2e271 100644
    > --- a/drivers/watchdog/ie6xx_wdt.c
    > +++ b/drivers/watchdog/ie6xx_wdt.c
    > @@ -271,6 +271,9 @@ static int ie6xx_wdt_remove(struct platform_device *pdev)
    > struct resource *res;
    >
    > res = platform_get_resource(pdev, IORESOURCE_IO, 0);
    > + if (!res)
    > + return -EINVAL;
    > +
    > ie6xx_wdt_stop(NULL);
    > watchdog_unregister_device(&ie6xx_wdt_dev);
    > ie6xx_wdt_debugfs_exit();
    >

    \
     
     \ /
      Last update: 2021-12-20 16:42    [W:3.753 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site