Messages in this thread | | | Date | Mon, 20 Dec 2021 09:38:06 -0600 | From | Eric Biggers <> | Subject | Re: [PATCH RESEND] random: use correct memory barriers for crng_node_pool |
| |
On Mon, Dec 20, 2021 at 04:17:59PM +0100, Jason A. Donenfeld wrote: > On Sun, Dec 19, 2021 at 3:52 AM Eric Biggers <ebiggers@kernel.org> wrote: > > + > > +static inline struct crng_state *select_crng(void) > > +{ > > + > > +static inline struct crng_state *select_crng(void) > > +{ > > Usually static inline is avoided in .c files. Any special reason why > we'd need this especially much here? Those functions are pretty small > and I assume will be inlined anyway on most architectures. > > I just did a test on x86_64 with GCC 11, and the same file was > produced with 'static' as with 'static inline'. Was there an > arch/config/compiler combo you were concerned about here?
No special reason, this is just a bad habit. I'm fine with omitting 'inline' here.
- Eric
| |