Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Mon, 20 Dec 2021 16:17:59 +0100 | Subject | Re: [PATCH RESEND] random: use correct memory barriers for crng_node_pool |
| |
On Sun, Dec 19, 2021 at 3:52 AM Eric Biggers <ebiggers@kernel.org> wrote: > + > +static inline struct crng_state *select_crng(void) > +{ > + > +static inline struct crng_state *select_crng(void) > +{
Usually static inline is avoided in .c files. Any special reason why we'd need this especially much here? Those functions are pretty small and I assume will be inlined anyway on most architectures.
I just did a test on x86_64 with GCC 11, and the same file was produced with 'static' as with 'static inline'. Was there an arch/config/compiler combo you were concerned about here?
Jason
| |