Messages in this thread | | | Subject | Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c | From | Dmitry Osipenko <> | Date | Mon, 20 Dec 2021 17:53:23 +0300 |
| |
20.12.2021 17:46, Peter Geis пишет: > +static int rk808_restart_notify(struct notifier_block *this, unsigned long mode, void *cmd) > +{ > + int ret; > + unsigned int reg, bit; > + struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);
Such code usually should be written in a form of reverse Xmas tree in kernel, but no need to respin just because of it. The patch looks good to me, thank you.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
| |