lkml.org 
[lkml]   [2021]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 33/71] rds: memory leak in __rds_conn_create()
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit 5f9562ebe710c307adc5f666bf1a2162ee7977c0 ]

    __rds_conn_create() did not release conn->c_path when loop_trans != 0 and
    trans->t_prefer_loopback != 0 and is_outgoing == 0.

    Fixes: aced3ce57cd3 ("RDS tcp loopback connection can hang")
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/rds/connection.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/rds/connection.c b/net/rds/connection.c
    index c85bd6340eaa7..92ff40e7a66cf 100644
    --- a/net/rds/connection.c
    +++ b/net/rds/connection.c
    @@ -253,6 +253,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
    * should end up here, but if it
    * does, reset/destroy the connection.
    */
    + kfree(conn->c_path);
    kmem_cache_free(rds_conn_slab, conn);
    conn = ERR_PTR(-EOPNOTSUPP);
    goto out;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-12-20 15:53    [W:3.629 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site