lkml.org 
[lkml]   [2021]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] usb: dwc2: Check for null res pointer
Date
Hi Jiasheng,

On 12/20/2021 12:09 PM, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.
>
> Fixes: 348becdcc319 ("usb: dwc2: fix "iomem 0x00000000" message")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2
>
> *Change 1. Correct the commit message.
> ---
> drivers/usb/dwc2/hcd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2a7828971d05..517743555b9c 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -5191,6 +5191,11 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
> hcd->has_tt = 1;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + retval = -EINVAL;
> + goto error1;
> + }
> +
> hcd->rsrc_start = res->start;
> hcd->rsrc_len = resource_size(res);
>
This patch already in code. Please check follow patch:

commit 856e6e8e0f9300befa87dde09edb578555c99a82
Author: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue Aug 31 16:42:36 2021 +0800
usb: dwc2: check return value after calling platform_get_resource()

Thanks,
Minas
\
 
 \ /
  Last update: 2021-12-20 10:45    [W:0.726 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site