lkml.org 
[lkml]   [2021]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH mm v4 34/39] kasan: simplify kasan_init_hw_tags
    Date
    From: Andrey Konovalov <andreyknvl@google.com>

    Simplify kasan_init_hw_tags():

    - Remove excessive comments in kasan_arg_mode switch.
    - Combine DEFAULT and ON cases in kasan_arg_stacktrace switch.

    Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

    ---

    Changes v1->v2:
    - Add this patch.
    ---
    mm/kasan/hw_tags.c | 12 +++---------
    1 file changed, 3 insertions(+), 9 deletions(-)

    diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c
    index 6509809dd5d8..99230e666c1b 100644
    --- a/mm/kasan/hw_tags.c
    +++ b/mm/kasan/hw_tags.c
    @@ -159,20 +159,15 @@ void __init kasan_init_hw_tags(void)

    switch (kasan_arg_mode) {
    case KASAN_ARG_MODE_DEFAULT:
    - /*
    - * Default to sync mode.
    - */
    + /* Default to sync mode. */
    fallthrough;
    case KASAN_ARG_MODE_SYNC:
    - /* Sync mode enabled. */
    kasan_mode = KASAN_MODE_SYNC;
    break;
    case KASAN_ARG_MODE_ASYNC:
    - /* Async mode enabled. */
    kasan_mode = KASAN_MODE_ASYNC;
    break;
    case KASAN_ARG_MODE_ASYMM:
    - /* Asymm mode enabled. */
    kasan_mode = KASAN_MODE_ASYMM;
    break;
    }
    @@ -180,14 +175,13 @@ void __init kasan_init_hw_tags(void)
    switch (kasan_arg_stacktrace) {
    case KASAN_ARG_STACKTRACE_DEFAULT:
    /* Default to enabling stack trace collection. */
    + fallthrough;
    + case KASAN_ARG_STACKTRACE_ON:
    static_branch_enable(&kasan_flag_stacktrace);
    break;
    case KASAN_ARG_STACKTRACE_OFF:
    /* Do nothing, kasan_flag_stacktrace keeps its default value. */
    break;
    - case KASAN_ARG_STACKTRACE_ON:
    - static_branch_enable(&kasan_flag_stacktrace);
    - break;
    }

    pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, stacktrace=%s)\n",
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-12-20 23:03    [W:2.926 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site