Messages in this thread | | | Subject | Re: [PATCH] watchdog: s3c2410: Fix getting the optional clock | From | Guenter Roeck <> | Date | Mon, 20 Dec 2021 13:08:11 -0800 |
| |
On 12/20/21 7:15 AM, Sam Protsenko wrote: > On Sun, 12 Dec 2021 at 19:50, Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> >> On 12/12/2021 18:02, Sam Protsenko wrote: >>> "watchdog_src" clock is optional and may not be present for some SoCs >>> supported by this driver. Nevertheless, in case the clock is provided >>> but some error happens during its getting, that error should be handled >>> properly. Use devm_clk_get_optional() API for that. Also report possible >>> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if >>> clock provider is not ready by the time WDT probe function is executed). >>> >>> Fixes: a4f3dc8d5fbc ("watchdog: s3c2410: Support separate source clock") >>> Reported-by: kernel test robot <lkp@intel.com> >>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >>> Suggested-by: Guenter Roeck <linux@roeck-us.net> >>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >>> --- >>> drivers/watchdog/s3c2410_wdt.c | 22 ++++++++++++---------- >>> 1 file changed, 12 insertions(+), 10 deletions(-) >>> >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> > > Hi Guenter, > > If there are no outstanding concerns, can you please apply this one? > Would be nice to see it in v5.17 if that's possible. >
I added the patch to my watchdog-next tree, but Wim handles all pull requests.
Thanks, Guenter
| |