Messages in this thread | | | Date | Mon, 20 Dec 2021 17:21:50 +0100 | From | Lukas Wunner <> | Subject | Re: [PATCH v2] PCI: Add defines for normal and subtractive PCI bridges |
| |
On Mon, Dec 20, 2021 at 03:51:40PM +0100, Pali Rohár wrote: > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -178,9 +178,9 @@ static pci_ers_result_t pcie_portdrv_mmio_enabled(struct pci_dev *dev) > */ > static const struct pci_device_id port_pci_ids[] = { > /* handle any PCI-Express port */ > - { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0) }, > + { PCI_DEVICE_CLASS(PCI_CLASS_BRIDGE_PCI_NORMAL, ~0) }, > /* subtractive decode PCI-to-PCI bridge, class type is 060401h */ > - { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0) }, > + { PCI_DEVICE_CLASS(PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE, ~0) },
Any harm in simply matching for 0x060400 with mask 0xffff00?
| |