Messages in this thread | | | Date | Thu, 2 Dec 2021 22:04:11 +0800 | Subject | Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations | From | Chao Yu <> |
| |
On 2021/12/2 12:15, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: >> Why not relocating this check before f2fs_map_blocks()?
Wait, it supports DIO in multi-device image after commit 71f2c8206202 ("f2fs: multidevice: support direct IO"), how about checking with f2fs_allow_multi_device_dio()?
Thanks,
>> >> Thanks, >> >>> + iomap->bdev = inode->i_sb->s_bdev; > > Are you talking about the check for !f2fs_is_multi_device()? It could go in > either location, but I think it makes the most sense to have it right before the > line that uses 'inode->i_sb->s_bdev', since that is the place which makes the > assumption that the filesystem has only one block device. > > - Eric >
| |