lkml.org 
[lkml]   [2021]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] RDMA/siw: Use max() instead of doing it manually
From
Date
-----"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com> wrote: -----

>To: bmt@zurich.ibm.com
>From: "Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>
>Date: 12/02/2021 11:08AM
>Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org,
>linux-kernel@vger.kernel.org, "Jiapeng Chong"
><jiapeng.chong@linux.alibaba.com>
>Subject: [EXTERNAL] [PATCH] RDMA/siw: Use max() instead of doing it
>manually
>
>Fix following coccicheck warning:
>
>./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING
>opportunity
>for max().
>
>Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index d15a1f9..a3dd2cb 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct
>ib_send_wr *core_wr,
> kbuf += core_sge->length;
> core_sge++;
> }
>- sqe->sge[0].length = bytes > 0 ? bytes : 0;
>+ sqe->sge[0].length = max(bytes, 0);
> sqe->num_sge = bytes > 0 ? 1 : 0;
>
> return bytes;
>--
>1.8.3.1
>
>
Looks good, thanks!

Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>

\
 
 \ /
  Last update: 2021-12-02 13:08    [W:0.039 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site