lkml.org 
[lkml]   [2021]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] locking/rtmutex: Fix incorrect spinning condition
Date


> When the lock owner is on CPU and not need resched, the current waiter
> need to be checked, if it not longer top the waiter, stop spinning.
>
>Incorrect grammar, should be "if it is no longer the top waiter". There is a similar typo in the existing code comment too.
>
>You can modify the subject line to [PATCH-tip ...] to indicate that it is supposed to be apply on top of the tip tree. Other than that, the patch looks good.

Thanks, Longman. I will modify it and resend.

Thanks,

Zqiang
>
>Cheers,
>Longman

>
> Fixes: c3123c431447 ("locking/rtmutex: Dont dereference waiter
> lockless")
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> ---
> v1->v2:
> Modify description information.
>
> kernel/locking/rtmutex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index
> 0c1f2e3f019a..8555c4efe97c 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -1383,7 +1383,7 @@ static bool rtmutex_spin_on_owner(struct rt_mutex_base *lock,
> * - the VCPU on which owner runs is preempted
> */
> if (!owner_on_cpu(owner) || need_resched() ||
> - rt_mutex_waiter_is_top_waiter(lock, waiter)) {
> + !rt_mutex_waiter_is_top_waiter(lock, waiter)) {
> res = false;
> break;
> }

\
 
 \ /
  Last update: 2021-12-20 02:54    [W:0.073 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site