Messages in this thread | | | Date | Sat, 18 Dec 2021 20:05:16 +0900 | From | Dominique Martinet <> | Subject | Re: [PATCH] 9p: fix unused-variable warning |
| |
Dominique Martinet wrote on Sat, Dec 04, 2021 at 09:04:04AM +0900: > Arnd Bergmann wrote on Fri, Dec 03, 2021 at 07:58:06PM +0100: > > From: Arnd Bergmann <arnd@arndb.de> > > > > The folio changes added a variable that is sometimes unused: > > > > fs/9p/vfs_addr.c: In function 'v9fs_release_page': > > fs/9p/vfs_addr.c:140:23: error: unused variable 'inode' [-Werror=unused-variable] > > 140 | struct inode *inode = folio_inode(folio); > > | ^~~~~ > > > > Make this clearer to the compiler by replacing the #ifdef > > with an equivalent if(IS_ENABLED()) check. > > > > Fixes: 78525c74d9e7 ("netfs, 9p, afs, ceph: Use folios") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Looks good to me, picking it up
Sorry it took me a while to actually do the picking up part, but this appears to have been a patch for linux-next back then and I didn't notice because the Fixes tag is incorrect (78525c74d9e7 didn't introduce the inode variable, it actually fixes a patch that never has been merged)
David since then fixed the warning differently in v2 of the patch (he moved the fscache_note_page_release() out of the ifdef), so I won't do anything with this even if in principle I tend to agree that if(IS_ENABLED()) lead to better compiler coverage
Thanks though! -- Dominique
| |