lkml.org 
[lkml]   [2021]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv"
Date
[Public]

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Friday, December 17, 2021 12:07
> To: Pandey, Ajit Kumar <AjitKumar.Pandey@amd.com>
> Cc: Stephen Boyd <sboyd@kernel.org>; linux-clk <linux-clk@vger.kernel.org>;
> Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj
> <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil-
> kumar.Dommati@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Rafael J. Wysocki <rafael@kernel.org>; Len
> Brown <lenb@kernel.org>; open list:ACPI <linux-acpi@vger.kernel.org>; open
> list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device
> property "is-rv"
>
> On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey
> <AjitKumar.Pandey@amd.com> wrote:
> >
> > Initially "is-rv" device property is added for 48MHz fixed clock
> > support on Raven or RV architecture. It's unused now as we moved
> > to pci device_id based selection to extend such support on other
> > architectures. This change removed unused code from acpi driver.
> >
> > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
> > Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com>
>
> Does this or the next patch depend on the rest of the series, or can I
> simply apply them both?

There are (intentional) dependencies within this series on the order. It
would be better for the whole series to come through one tree.

>
> > ---
> > drivers/acpi/acpi_apd.c | 3 ---
> > include/linux/platform_data/clk-fch.h | 1 -
> > 2 files changed, 4 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> > index 6e02448d15d9..6913e9712852 100644
> > --- a/drivers/acpi/acpi_apd.c
> > +++ b/drivers/acpi/acpi_apd.c
> > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data
> *pdata)
> > if (ret < 0)
> > return -ENOENT;
> >
> > - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
> > - clk_data->is_rv = obj->integer.value;
> > -
> > list_for_each_entry(rentry, &resource_list, node) {
> > clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
> > resource_size(rentry->res));
> > diff --git a/include/linux/platform_data/clk-fch.h
> b/include/linux/platform_data/clk-fch.h
> > index b9f682459f08..850ca776156d 100644
> > --- a/include/linux/platform_data/clk-fch.h
> > +++ b/include/linux/platform_data/clk-fch.h
> > @@ -12,7 +12,6 @@
> >
> > struct fch_clk_data {
> > void __iomem *base;
> > - u32 is_rv;
> > };
> >
> > #endif /* __CLK_FCH_H */
> > --
> > 2.25.1
> >
\
 
 \ /
  Last update: 2021-12-17 19:19    [W:0.127 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site