Messages in this thread | | | Date | Fri, 17 Dec 2021 19:11:15 +0100 | Subject | Re: [PATCH v1 03/11] mm: simplify hugetlb and file-THP handling in __page_mapcount() | From | David Hildenbrand <> |
| |
On 17.12.21 19:06, Mike Kravetz wrote: > On 12/17/21 03:30, David Hildenbrand wrote: >> Let's return early for hugetlb, which really only relies on the compound >> mapcount so far and does not support PageDoubleMap() yet. Use the chance > > It is too early to say if hugetlb double mapping will use PageDoubleMap(). > I do not think (hope) it will be necessary. So, I think you can drop mention > of it here.
Desires have most certainly been expressed from a couple of parties -- to PTE map huge pages :) Hopefully we'll find a way to avoid PageDoubleMap, I agree.
Dropping the comment!
> >> to cleanup the file-THP case to make it easier to grasp. While at it, use >> head_compound_mapcount(). >> >> This is a preparation for further changes. >> >> Reviewed-by: Peter Xu <peterx@redhat.com> >> Signed-off-by: David Hildenbrand <david@redhat.com> > > Acked-by: Mike Kravetz <mike.kravetz@oracle.com> >
Thanks!
-- Thanks,
David / dhildenb
| |