lkml.org 
[lkml]   [2021]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 回复:[PATC H -next] f2fs: Simplify bool conversion
On 12/17, Yang.Lee wrote:
> "Why not this?
> sbi->gc_urgent_high_limited = t;"
>
> Since 't' is an unsigned long type and 'gc_urgent_high_limited' is a bool type, the assignment operation will cause a new warning.

Huh, that doesn't allow auto casting as well.

>
>
> ------------------------------------------------------------------
> 发件人:Jaegeuk Kim <jaegeuk@kernel.org>
> 发送时间:2021年12月17日(星期五) 03:27
> 收件人:Yang Li <yang.lee@linux.alibaba.com>
> 抄 送:chao <chao@kernel.org>; linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>; linux-kernel <linux-kernel@vger.kernel.org>; Abaci Robot <abaci@linux.alibaba.com>
> 主 题:Re: [PATCH -next] f2fs: Simplify bool conversion
>
> On 12/15, Yang Li wrote:
> > Fix the following coccicheck warning:
> > ./fs/f2fs/sysfs.c:491:41-46: WARNING: conversion to bool not needed here
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > fs/f2fs/sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 9e1cf44642ae..530c36b89bf1 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -488,7 +488,7 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
> >
> > if (!strcmp(a->attr.name, "gc_urgent_high_remaining")) {
> > spin_lock(&sbi->gc_urgent_high_lock);
> > - sbi->gc_urgent_high_limited = t == 0 ? false : true;
> > + sbi->gc_urgent_high_limited = t != 0;
>
> Why not this?
> sbi->gc_urgent_high_limited = t;
>
> > sbi->gc_urgent_high_remaining = t;
> > spin_unlock(&sbi->gc_urgent_high_lock);
> >
> > --
> > 2.20.1.7.g153144c
>

\
 
 \ /
  Last update: 2021-12-17 17:53    [W:0.116 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site