lkml.org 
[lkml]   [2021]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
Date
> From: Dan Carpenter <dan.carpenter@oracle.com>
> ...
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Sure. Will add the above tags in the fix patch.

> smatch warnings:
> drivers/edac/i10nm_base.c:256 i10nm_get_hbm_munits() warn: 'mbase' not released on lines: 249.
> ...
> mbase =ioremap(base + off, I10NM_HBM_IMC_MMIO_SIZE);
> ^^^^^^^^^^^^^^^^
>...
> if (!I10NM_IS_HBM_IMC(mcmtr)) {
> i10nm_printk(KERN_ERR, "This isn't an hbm mc!\n");
> return -ENODEV;
> }
> No clean up before the return.

Thanks for catching this issue. Will fix it.

- Qiuxu

\
 
 \ /
  Last update: 2021-12-17 14:29    [W:0.653 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site