Messages in this thread | | | Date | Fri, 17 Dec 2021 12:37:30 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2] isoc: mediatek: potential use of error pointer |
| |
On Fri, Dec 17, 2021 at 08:08:45PM +0800, Jiasheng Jiang wrote:
> - for (i = CLK_NONE + 1; i < CLK_MAX; i++) > + for (i = CLK_NONE + 1; i < CLK_MAX; i++) { > clk[i] = devm_clk_get(&pdev->dev, clk_names[i]); > + if (!clk[i]) > + return ERR_PTR(-ENOMEM);
That's not how to check the error code from clk_get(), still has the problem with unconditionally using -ENOMEM. Please at least check that the patches you are sending build...
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. [unhandled content-type:application/pgp-signature] | |