Messages in this thread | | | Date | Fri, 17 Dec 2021 12:08:25 +0000 | Subject | Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction | From | Robin Murphy <> |
| |
On 2021-12-16 08:02, Christoph Hellwig wrote: >> @@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo, >> unsigned long pfn_hi); >> void init_iova_domain(struct iova_domain *iovad, unsigned long granule, >> unsigned long start_pfn); >> -int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb); >> +int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain); > > Overly long line here.
Fear not, it disappears again in the final patch. In cases like this I much prefer to minimise the amount of churn within the series, to keep the patches focused on the meaningful changes.
> Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the reviews!
Robin.
| |