lkml.org 
[lkml]   [2021]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] crypto: hisilicon - replace 'smp_processor_id' with the raw version of the macro
On Mon, Dec 06, 2021 at 06:51:09PM +0800, Kai Ye wrote:
> smp_processor_id() is unsafe if it's used in a preemption-on critical
> section. It will cause the call trace when the preemption-on and sets the
> CONFIG_DEBUG_PREEMPT. So replace 'smp_processor_id' with the raw version of
> the marco in preemptible to avoid the following call trace:

What you wrote here makes zero sense. If smp_processor_id is
unsafe then the raw version is even more unsafe.

Please provide the actual justification as to why it is *safe*.

Even better, put the justification in the patch as a comment
instead of the changelog.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2021-12-17 06:14    [W:0.037 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site