Messages in this thread | | | Subject | Re: [PATCH v2 1/2] mtd: spi-nor: micron-st: make mt25ql02g/mt25qu02g match more specific, add 4B opcodes | From | Matthias Schiffer <> | Date | Fri, 17 Dec 2021 11:07:15 +0100 |
| |
On Fri, 2021-12-17 at 00:22 +0530, Pratyush Yadav wrote: > Hi Matthias, > > On 07/10/21 02:08PM, Matthias Schiffer wrote: > > Change the mt25ql02g/mt25qu02g entries to include > > SPI_NOR_4B_OPCODES. In > > addition, the SPI_NOR_DUAL_READ flag is added to mt25ql02g; this > > seems > > to have been an accidental omission, as mt25ql02g and mt25qu02g > > should > > support the same features. > > The way flags are specified are changed a bit. See [0]. Please re- > roll > your patch to use the new flag types. If this flash supports SFDP > you > should ideally just need to set the sfdp flag to true and the core > should take care of the rest. Test reports with the new changes would > be > much appreciated :-)
Will do. Is there an easy way to check which features the kernel detected from the SFDP with the new code?
> > > In addition, the entries are made more specific by matching on the > > mt25q > > extended ID, like it is already done for the smaller n25q > > derivatives. > > It is unclear whether n25q derivatives with 2Gbit exist that do not > > support 4B opcodes (like it is the case for sizes up to 512MBit), > > so we > > do not have a match for such variants anymore (as we wouldn't even > > know > > how to name such hypothetical models). > > Sounds good to me. > > > The changes were tested with a mt25qu01g, which should support the > > same > > features as the mt25ql02g/mt25qu02g. > > > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com > > > > > --- > > > > [0] > https://patchwork.ozlabs.org/project/linux-mtd/list/?series=275622&state=%2A&archive=both >
| |