lkml.org 
[lkml]   [2021]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: linux-next: Tree for Dec 17 (drivers/reset/reset-starfive-jh7100.c)
Hi Randy,

On Fri, 17 Dec 2021 at 22:48, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 12/17/21 05:33, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20211216:
> >
>
> on i386:
>
> ../drivers/reset/reset-starfive-jh7100.c: In function ‘jh7100_reset_update’:
> ../drivers/reset/reset-starfive-jh7100.c:81:10: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
> value = readq(reg_assert);
> ^~~~~
> ../drivers/reset/reset-starfive-jh7100.c:86:2: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
> writeq(value, reg_assert);
> ^~~~~~

Yes, It needs to include <linux/io-64-nonatomic-lo-hi.h> for compile
testing to work on 32bit architectures without readq.

Arnd: Do I just send a patch or do I redo the pull-request?

/Emil

\
 
 \ /
  Last update: 2021-12-17 22:54    [W:0.057 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site