Messages in this thread Patch in this message | | | From | xkernel.wang@foxmail ... | Subject | [PATCH v2] nfs: nfs4clinet: check the return value of kstrdup() | Date | Fri, 17 Dec 2021 01:01:33 +0800 |
| |
From: Xiaoke Wang <xkernel.wang@foxmail.com>
kstrdup() returns NULL when some internal memory errors happen, it is better to check the return value of it so to catch the memory error in time.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> --- Changelogs: move the check under if block. --- fs/nfs/nfs4client.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index af57332..ed06b68 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c @@ -1368,8 +1368,11 @@ int nfs4_update_server(struct nfs_server *server, const char *hostname, } nfs_put_client(clp); - if (server->nfs_client->cl_hostname == NULL) + if (server->nfs_client->cl_hostname == NULL) { server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL); + if (server->nfs_client->cl_hostname == NULL) + return -ENOMEM; + } nfs_server_insert_lists(server); return nfs_probe_destination(server); --
| |