lkml.org 
[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 57/68] afs: Fix afs_write_end() to handle len > page size
    On Thu, Dec 16, 2021 at 8:22 AM David Howells <dhowells@redhat.com> wrote:
    >
    > It is possible for the len argument to afs_write_end() to overrun the end
    > of the page (len is used to key the size of the page in afs_write_start()
    > when compound pages become a regular thing).

    This smells like a bug in the caller.

    It's just insane to call "write_end()" with a range that doesn't
    actually fit in the page provided.

    Exactly how does that happen, and why should AFS deal with it, not
    whoever called write_end()?

    Linus

    \
     
     \ /
      Last update: 2021-12-16 17:34    [W:5.083 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site