Messages in this thread | | | Date | Fri, 17 Dec 2021 00:02:34 +0900 | From | Masami Hiramatsu <> | Subject | Re: [RFC][PATCH v6 3/5] trace/README: Document objtrace trigger syntax |
| |
Hi Jeff,
On Tue, 30 Nov 2021 00:49:49 +0800 Jeff Xie <xiehuan09@gmail.com> wrote:
> Add a short description of the use of objtrace trigger.
Please merge this into the [1/5] and [2/5], because the changes of "a new feature" and "the existance of the feature which kernel indicates" must be atomic.
My recommendation is
- add following line in the first patch
"\t objtrace:add:obj[:count][if <filter>]\n"
- and update it as following in the next patch according to the changes
"\t objtrace:add:obj[,offset][:type][:count][if <filter>]\n"
Thank you!
> > Signed-off-by: Jeff Xie <xiehuan09@gmail.com> > --- > kernel/trace/trace.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 88de94da596b..a84b6813769e 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -5590,6 +5590,9 @@ static const char readme_msg[] = > "\t enable_hist:<system>:<event>\n" > "\t disable_hist:<system>:<event>\n" > #endif > +#ifdef CONFIG_TRACE_OBJECT > + "\t objtrace:add:obj[,offset][:type][:count][if <filter>]\n" > +#endif > #ifdef CONFIG_STACKTRACE > "\t\t stacktrace\n" > #endif > -- > 2.25.1 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |