[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] hwmon : (mr75203) fix macro typo
On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> the correct value should be 0x100. The register ip_tmr is expressed
> in units of IP clk cycles, in accordance with the datasheet.
> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.

Should you provide Fixes tag?


> -#define POWER_DELAY_CYCLE_256 0x80
> +#define POWER_DELAY_CYCLE_256 0x100
> #define POWER_DELAY_CYCLE_64 0x40

I;m wondering why they are in hex? Perhaps the decimal is better for both.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2021-12-16 15:20    [W:0.073 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site