Messages in this thread | | | Date | Thu, 16 Dec 2021 12:24:19 +0200 | From | Jyri Sarha <> | Subject | Re: [PATCH v3] drm/tilcdc: add const to of_device_id |
| |
On 2021-12-16 11:55, Xiang wangx wrote: > struct of_device_id should normally be const. > > Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Thanks, Jyri
> --- > > Changes since v1 > * add const in line 63 > > Changes since v2 > * removed line 63 > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 3ddb7c710a3d..cc567c87057d 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -60,8 +60,6 @@ void tilcdc_module_cleanup(struct tilcdc_module *mod) > list_del(&mod->list); > } > > -static struct of_device_id tilcdc_of_match[]; > - > static int tilcdc_atomic_check(struct drm_device *dev, > struct drm_atomic_state *state) > { > @@ -587,7 +585,7 @@ static int tilcdc_pdev_remove(struct > platform_device *pdev) > return 0; > } > > -static struct of_device_id tilcdc_of_match[] = { > +static const struct of_device_id tilcdc_of_match[] = { > { .compatible = "ti,am33xx-tilcdc", }, > { .compatible = "ti,da850-tilcdc", }, > { },
| |