lkml.org 
[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 1/1] usb: dwc2: gadget: don't try to disable ep0 in dwc2_hsotg_suspend
    Date
    On 12/7/2021 5:01 PM, Amelie Delaunay wrote:
    > Calling dwc2_hsotg_ep_disable on ep0 (in/out) will lead to the following
    > logs before returning -EINVAL:
    > dwc2 49000000.usb-otg: dwc2_hsotg_ep_disable: called for ep0
    > dwc2 49000000.usb-otg: dwc2_hsotg_ep_disable: called for ep0
    >
    > To avoid these two logs while suspending, start disabling the endpoint
    > from the index 1, as done in dwc2_hsotg_udc_stop:
    >
    > /* all endpoints should be shutdown */
    > for (ep = 1; ep < hsotg->num_of_eps; ep++) {
    > if (hsotg->eps_in[ep])
    > dwc2_hsotg_ep_disable_lock(&hsotg->eps_in[ep]->ep);
    > if (hsotg->eps_out[ep])
    > dwc2_hsotg_ep_disable_lock(&hsotg->eps_out[ep]->ep);
    > }
    >
    > Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>

    Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>

    > ---
    > drivers/usb/dwc2/gadget.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
    > index b884a83b26a6..ee31f9a328da 100644
    > --- a/drivers/usb/dwc2/gadget.c
    > +++ b/drivers/usb/dwc2/gadget.c
    > @@ -5086,7 +5086,7 @@ int dwc2_hsotg_suspend(struct dwc2_hsotg *hsotg)
    > hsotg->gadget.speed = USB_SPEED_UNKNOWN;
    > spin_unlock_irqrestore(&hsotg->lock, flags);
    >
    > - for (ep = 0; ep < hsotg->num_of_eps; ep++) {
    > + for (ep = 1; ep < hsotg->num_of_eps; ep++) {
    > if (hsotg->eps_in[ep])
    > dwc2_hsotg_ep_disable_lock(&hsotg->eps_in[ep]->ep);
    > if (hsotg->eps_out[ep])

    \
     
     \ /
      Last update: 2021-12-16 11:21    [W:13.871 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site