lkml.org 
[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture
On Thu, 16 Dec 2021 at 07:00, Harinder Singh <sharinder@google.com> wrote:
>
> Describe the components of KUnit and how the kernel mode parts
> interact with kunit_tool.
>
> Signed-off-by: Harinder Singh <sharinder@google.com>
> ---
> .../dev-tools/kunit/architecture.rst | 204 ++++++++++++++++++
> Documentation/dev-tools/kunit/index.rst | 2 +
> .../kunit/kunit_suitememorydiagram.png | Bin 0 -> 24174 bytes
> Documentation/dev-tools/kunit/start.rst | 1 +
> 4 files changed, 207 insertions(+)
> create mode 100644 Documentation/dev-tools/kunit/architecture.rst
> create mode 100644 Documentation/dev-tools/kunit/kunit_suitememorydiagram.png

In response to the other email: Adding binary blobs just creates
problems, for comparing different versions, and general bloating the
whole repo, where better alternatives exist.

I suppose an ASCII diagram is a bit primitive. :-)

However, SVG files on the other hand are not binary blobs, they are
text-markup based (XML), and e.g. diffing them often provides useful
information about what changed. SVG also has the benefit of being
vector graphics, and not being limited to one resolution.

Looking at the diagram you added, I think this can easily be turned
into vector graphics, and most likely will not use up 24KiB as a
result.

Thanks,
-- Marco

\
 
 \ /
  Last update: 2021-12-16 11:16    [W:0.148 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site