lkml.org 
[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH infiniband-next] drivers/infiniband: remove redundant err variable
On Wed, Dec 15, 2021 at 2:06 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Thanks.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2021-12-16 10:05    [W:0.090 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site