Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 16 Dec 2021 09:47:40 +0100 | Subject | Re: [PATCH] irqchip/renesas-irqc: Use platform_get_irq_optional() to get the interrupt |
| |
Hi Prabhakar,
On Thu, Dec 16, 2021 at 12:50 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypassed the hierarchical setup and messed up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional(). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/irqchip/irq-renesas-irqc.c > +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -142,13 +141,15 @@ static int irqc_probe(struct platform_device *pdev) > > /* allow any number of IRQs between 1 and IRQC_IRQ_MAX */ > for (k = 0; k < IRQC_IRQ_MAX; k++) { > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, k); > - if (!irq) > + ret = platform_get_irq_optional(pdev, k); > + if (ret == -EPROBE_DEFER) > + goto err_runtime_pm_disable; > + if (ret < 0) > break;
Same comment as for the other patch: shouldn't all errors be considered fatal, except for -ENXIO (no interrupt)? > > p->irq[k].p = p; > p->irq[k].hw_irq = k; > - p->irq[k].requested_irq = irq->start; > + p->irq[k].requested_irq = ret; > } > > p->number_of_irqs = k;
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |