Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v2 2/2] dt-bindings: Migrate DA9063 text bindings to YAML | Date | Thu, 16 Dec 2021 21:47:33 -0600 |
| |
On Thu, 16 Dec 2021 17:40:37 +0100, Alexandre Ghiti wrote: > DA9063 devices bindings used text format, so migrate those bindings to YAML > format before adding any new bindings. > > Signed-off-by: Alexandre Ghiti <alexandre.ghiti@canonical.com> > --- > > Changes in v2: > - Fix all errors detected with make dt_binding_checks > > .../bindings/input/da9063-onkey.yaml | 39 ++++++ > .../devicetree/bindings/mfd/da9063.txt | 111 ------------------ > .../devicetree/bindings/mfd/da9063.yaml | 105 +++++++++++++++++ > .../bindings/regulator/da9063-regulator.yaml | 51 ++++++++ > .../devicetree/bindings/rtc/da9063-rtc.yaml | 31 +++++ > .../bindings/watchdog/da9063-watchdog.yaml | 31 +++++ > 6 files changed, 257 insertions(+), 111 deletions(-) > create mode 100644 Documentation/devicetree/bindings/input/da9063-onkey.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt > create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml > create mode 100644 Documentation/devicetree/bindings/regulator/da9063-regulator.yaml > create mode 100644 Documentation/devicetree/bindings/rtc/da9063-rtc.yaml > create mode 100644 Documentation/devicetree/bindings/watchdog/da9063-watchdog.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: 'interrupt-controller', 'onkey', 'regulators', 'rtc', 'wdt' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/trivial-devices.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: regulators: 'compatible' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: regulators: 'bcore1', 'ldo11' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml: da9063@58: 'wdt' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/da9063.yaml
doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/input/da9062-onkey.txt: Documentation/devicetree/bindings/mfd/da9063.txt
See https://patchwork.ozlabs.org/patch/1569315
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |