[lkml]   [2021]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] extcon: fix extcon_get_extcon_dev() error handling
On 12/16/21 4:52 PM, Dan Carpenter wrote:
> On Thu, Dec 16, 2021 at 03:39:46PM +0900, Chanwoo Choi wrote:
>> Hi Dan,
>> First of all, sorry for late reply.
>> There is one issue. About this issue, I already discussed on patch[1]
>> [1]
>> extcon_get_extcon_dev() is used for anywhere except for probe step.
>> But EPROBE_DEFER is only used on probe step.
>> So that it is not clear to return EPROBE_DEFER from extcon_get_extcon_dev()
>> because extcon_get_extcon_dev() never know either call it on probe function
>> or not.
> Currently extcon_get_extcon_dev() is only called from probe so it's not
> an issue.

Even if extcon_get_extcon_dev() is used on probe until now,
it is possible to use on anywhere as I commented.

It is difficult to agree this approach without any other solution.

Basically, the subsystem core never know either probe time or not.
It means that this issue should be handled in each device driver.

> It's impossible to know what future programmers will want, but I feel
> like this change probably makes it easier for them.

Best Regards,
Chanwoo Choi
Samsung Electronics

 \ /
  Last update: 2021-12-16 09:02    [W:0.122 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site