lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] perf intel-pt: Fix parsing of VM time correlation arguments
Hi Adrian,

On Wed, Dec 15, 2021 at 12:07 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Parser did not take ':' into account.
>
> Example:
>
> Before:
>
> $ perf record -e intel_pt//u uname
> Linux
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.026 MB perf.data ]
> $ perf inject -i perf.data --vm-time-correlation="dry-run 123"
> $ perf inject -i perf.data --vm-time-correlation="dry-run 123:456"
> Failed to parse VM Time Correlation options
> 0x620 [0x98]: failed to process type: 70 [Invalid argument]
> $
>
> After:
>
> $ perf inject -i perf.data --vm-time-correlation="dry-run 123:456"
> $
>
> Fixes: e3ff42bdebcfe ("perf intel-pt: Parse VM Time Correlation options and set up decoding")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
> tools/perf/util/intel-pt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
> index 10c3187e4c5a..e8613cbda331 100644
> --- a/tools/perf/util/intel-pt.c
> +++ b/tools/perf/util/intel-pt.c
> @@ -3625,6 +3625,7 @@ static int intel_pt_parse_vm_tm_corr_arg(struct intel_pt *pt, char **args)
> *args = p;
> return 0;
> }
> + p += 1;
> while (1) {
> vmcs = strtoull(p, &p, 0);
> if (errno)
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2021-12-15 19:05    [W:0.068 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site