lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/43] kcsan: clang: retire CONFIG_KCSAN_KCOV_BROKEN
    On Tue, Dec 14, 2021 at 05:20:19PM +0100, Alexander Potapenko wrote:
    > kcov used to be broken prior to Clang 11, but right now that version is
    > already the minimum required to build with KCSAN, that is why we don't
    > need KCSAN_KCOV_BROKEN anymore.

    Just to check, how is that requirement enforced?

    I see the core Makefiles enforce 10.0.1+, but I couldn't spot an explicit
    version dependency in Kconfig.kcsan.

    Otherwise, this looks good to me!

    Mark.

    > Suggested-by: Marco Elver <elver@google.com>
    > Signed-off-by: Alexander Potapenko <glider@google.com>
    > ---
    > Link: https://linux-review.googlesource.com/id/Ida287421577f37de337139b5b5b9e977e4a6fee2
    > ---
    > lib/Kconfig.kcsan | 11 -----------
    > 1 file changed, 11 deletions(-)
    >
    > diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
    > index e0a93ffdef30e..b81454b2a0d09 100644
    > --- a/lib/Kconfig.kcsan
    > +++ b/lib/Kconfig.kcsan
    > @@ -10,21 +10,10 @@ config HAVE_KCSAN_COMPILER
    > For the list of compilers that support KCSAN, please see
    > <file:Documentation/dev-tools/kcsan.rst>.
    >
    > -config KCSAN_KCOV_BROKEN
    > - def_bool KCOV && CC_HAS_SANCOV_TRACE_PC
    > - depends on CC_IS_CLANG
    > - depends on !$(cc-option,-Werror=unused-command-line-argument -fsanitize=thread -fsanitize-coverage=trace-pc)
    > - help
    > - Some versions of clang support either KCSAN and KCOV but not the
    > - combination of the two.
    > - See https://bugs.llvm.org/show_bug.cgi?id=45831 for the status
    > - in newer releases.
    > -
    > menuconfig KCSAN
    > bool "KCSAN: dynamic data race detector"
    > depends on HAVE_ARCH_KCSAN && HAVE_KCSAN_COMPILER
    > depends on DEBUG_KERNEL && !KASAN
    > - depends on !KCSAN_KCOV_BROKEN
    > select STACKTRACE
    > help
    > The Kernel Concurrency Sanitizer (KCSAN) is a dynamic
    > --
    > 2.34.1.173.g76aa8bc2d0-goog
    >

    \
     
     \ /
      Last update: 2021-12-15 14:34    [W:4.040 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site