lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] reset: renesas: Check return value of reset_control_deassert()
Date

Hi Heiner,

Thanks for the patch

> Subject: [PATCH] reset: renesas: Check return value of
> reset_control_deassert()
>
> Deasserting the reset is vital, therefore bail out in case of error.
>
> Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> index 1e8315038..a8dde4606 100644
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct
> platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->rstc),
> "failed to get reset\n");
>
> - reset_control_deassert(priv->rstc);
> + error = reset_control_deassert(priv->rstc);
> + if (error)
> + return error;
>
> priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
> priv->rcdev.of_reset_n_cells = 1;
> --
> 2.34.1

\
 
 \ /
  Last update: 2021-12-15 11:30    [W:0.135 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site