Messages in this thread | | | Date | Wed, 15 Dec 2021 13:03:59 +0800 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH] media: mtk-vcodec: potential dereference of null pointer |
| |
On Wed, Dec 15, 2021 at 11:28:34AM +0800, Jiasheng Jiang wrote: > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c > index cd27f637dbe7..769228093e48 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c > @@ -102,6 +102,8 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_vpu_init(struct mtk_vcodec_dev *dev, > vpu_wdt_reg_handler(fw_pdev, mtk_vcodec_vpu_reset_handler, dev, rst_id); > > fw = devm_kzalloc(&dev->plat_dev->dev, sizeof(*fw), GFP_KERNEL); > + if (!fw) > + return ERR_PTR(-EINVAL);
It should return -ENOMEM for the case.
| |