lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 03/10] ASoC: cs35l41: Move power initializations to reg_sequence
On Tue, Dec 14, 2021 at 01:59:52PM +0000, Lucas Tanure wrote:
> + { CS35L41_PWR_CTRL2, 0x00000000 },
> + { CS35L41_AMP_GAIN_CTRL, 0x00000000 },
> };
> - ret = regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
> - CS35L41_AMP_EN_MASK, 0);
> - if (ret < 0) {
> - dev_err(cs35l41->dev, "Write CS35L41_PWR_CTRL2 failed: %d\n", ret);
> - goto err;
> - }
> -
> - ret = regmap_update_bits(cs35l41->regmap, CS35L41_AMP_GAIN_CTRL,
> - CS35L41_AMP_GAIN_PCM_MASK, 0);
> - if (ret < 0) {
> - dev_err(cs35l41->dev, "Write CS35L41_AMP_GAIN_CTRL failed: %d\n", ret);
> - goto err;
> - }

Sorry for not spotting earlier but just noticed these two writes
are update bits, so you shouldn't just be setting the values to
zero in the patch you just want to clear the relevant bit.

Thanks,
Charles

\
 
 \ /
  Last update: 2021-12-15 10:11    [W:0.079 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site