lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: i2c: ov8865: Neaten unnecessary indentation
From
Date
On Wed, 2021-12-15 at 10:01 +0200, Sakari Ailus wrote:
> Hi Joe
>
> On Tue, Dec 07, 2021 at 06:47:45AM -0800, Joe Perches wrote:
> > On Tue, 2021-12-07 at 14:24 +0200, Sakari Ailus wrote:
> > > Hi Joe (and Paul),
> >
> > > I guess this patch is fine as such but there seems to be a problem in error
> > > handling here: all regulators are disabled if there's a problem enabling
> > > one of them.
> > >
> > > Would it be possible to fix this as well?
> >
> > I've no hardware to test, so I've no idea if that's the right thing to do.
>
> I don't have the hardware either.
>
> But I can tell that you shouldn't disable a regulator you haven't enabled
> to begin with. Bugs (fixes of which probably should go to stable trees)
> need to be fixed before reworking the code.

I'm just fixing the ugly code.
You are welcome to fix what you believe to be logical defects.


\
 
 \ /
  Last update: 2021-12-15 09:08    [W:0.696 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site