Messages in this thread | | | Date | Wed, 15 Dec 2021 09:55:47 +0200 | Subject | Re: [PATCH v2 4/6] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters | From | Jarkko Nikula <> |
| |
On 12/13/21 20:00, Andy Shevchenko wrote: > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> > > The data type of hcnt and lcnt in the struct dw_i2c_dev is of type u16. > It's better to have same data type in struct dw_scl_sda_cfg as well. > > Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > v2: added tag (Jarkko) > > drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > I proposed this to be first before questionable cleanups since this fixes existing confusion (noted by Wolfram not any of us). Same to 5-6/6.
Jarkko
| |