Messages in this thread | | | From | Rob Herring <> | Date | Wed, 15 Dec 2021 19:10:57 -0600 | Subject | Re: [PATCH] dt-bindings: timer: add #size-cells 2 for ARM |
| |
On Wed, Dec 15, 2021 at 8:45 AM David Heidelberg <david@ixit.cz> wrote: > > It's already widely used by dt-schemas, so I blindly assume it's correct. > > Fixes warnings as: > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: timer@17c90000: #size-cells:0:0: 1 was expected > From schema: Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
That's somewhat on purpose. There's no reason the timer needs >32-bits of address or size. Sadly, QCom has ignored the warnings and just copy-n-pasted the same thing over and over.
> > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml > index cd2176cad53a..c061bb90b8e7 100644 > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml > @@ -30,7 +30,7 @@ properties: > enum: [1, 2] > > '#size-cells': > - const: 1 > + enum: [1, 2] > > ranges: true > > -- > 2.34.1 >
| |