Messages in this thread | | | Date | Thu, 16 Dec 2021 09:10:40 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v17 03/10] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel() |
| |
On 12/15/21 at 02:28pm, Borislav Petkov wrote: > On Fri, Dec 10, 2021 at 02:55:26PM +0800, Zhen Lei wrote: > > @@ -518,7 +519,7 @@ static void __init reserve_crashkernel(void) > > } > > } > > > > - if (crash_base >= (1ULL << 32) && reserve_crashkernel_low()) { > > + if (crash_base >= CRASH_ADDR_LOW_MAX && reserve_crashkernel_low()) { > > memblock_phys_free(crash_base, crash_size); > > return; > > } > > That's not a equivalent transformation on X86_32.
reserve_crashkernel_low() always return 0 on x86_32, so the not equivalent transformation for x86_32 doesn't matter, I think.
| |