lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: atmel: Use platform_get_irq() to get the interrupt
Hello Rob,

On 15/12/2021 16:48:31-0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> continuing to use static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/tty/serial/atmel_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 2c99a47a2535..9e57bfe523cf 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2479,7 +2479,7 @@ static int atmel_init_port(struct atmel_uart_port *atmel_port,
> port->fifosize = 1;
> port->dev = &pdev->dev;
> port->mapbase = mpdev->resource[0].start;

Shouldn't you fix that one at the same time?

> - port->irq = mpdev->resource[1].start;
> + port->irq = platform_get_irq(mpdev, 0);
> port->rs485_config = atmel_config_rs485;
> port->iso7816_config = atmel_config_iso7816;
> port->membase = NULL;
> --
> 2.32.0
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2021-12-16 00:38    [W:0.141 / U:1.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site