lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] of: unneed to initialise statics to 0 or NULL
On Sun, Dec 12, 2021 at 03:14:54PM +0800, Jason Wang wrote:
> Static variables do not need to be initialised to 0 or NULL,
> because compilers will initialise all uninitialised statics
> to 0 or NULL. Thus, remove the unneeded initializations.
>

Not required, but I think it helps statics stand out more as-is.

> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/of/pdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/pdt.c b/drivers/of/pdt.c
> index 7eda43c66c91..37d02fcb81d0 100644
> --- a/drivers/of/pdt.c
> +++ b/drivers/of/pdt.c
> @@ -40,7 +40,7 @@ static inline void irq_trans_init(struct device_node *dp) { }
>
> static char * __init of_pdt_build_full_name(struct device_node *dp)
> {
> - static int failsafe_id = 0; /* for generating unique names on failure */
> + static int failsafe_id; /* for generating unique names on failure */
> const char *name;
> char path[256];
> char *buf;
> @@ -67,7 +67,7 @@ static struct property * __init of_pdt_build_one_prop(phandle node, char *prev,
> void *special_val,
> int special_len)
> {
> - static struct property *tmp = NULL;
> + static struct property *tmp;
> struct property *p;
> int err;
>
> --
> 2.34.1
>
>

\
 
 \ /
  Last update: 2021-12-15 21:08    [W:0.123 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site