lkml.org 
[lkml]   [2021]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] of/fdt: Don't worry about non-memory region overlap for no-map
Quoting Mike Rapoport (2021-12-15 02:01:59)
> On Wed, Dec 15, 2021 at 11:49:37AM +0200, Mike Rapoport wrote:
> >
> > On Tue, Dec 14, 2021 at 11:20:11PM -0800, Stephen Boyd wrote:
> > > @@ -482,9 +482,11 @@ static int __init early_init_dt_reserve_memory_arch(phys_addr_t base,
> > > if (nomap) {
> > > /*
> > > * If the memory is already reserved (by another region), we
> > > - * should not allow it to be marked nomap.
> > > + * should not allow it to be marked nomap, but don't worry
> > > + * if the region isn't memory as it won't be mapped.
> > > */
> > > - if (memblock_is_region_reserved(base, size))
> > > + if (memblock_overlaps_region(&memblock.memory, base, size) &&
> > > + memblock_is_region_reserved(base, size))
>
> One more small thing. Maybe add pr_warn() here?
>

There's already a print in __reserved_mem_reserve_reg() when this
function returns an error so it doesn't seem very useful to add another
print.

\
 
 \ /
  Last update: 2021-12-15 20:24    [W:0.062 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site